Skip to content

Make the OptoHybrid configuration stricter

Laurent Petre requested to merge feature/stricter-optohybrid-configuration into main

Description

This MR is at first a follow-up on !309 which proved to be useful in the initialization of the trigger links (but less in the programming of the GE1/1 OptoHybrid FPGA). In more detail, the following changes are implemented:

  1. Ensure that the local readout output file can be open (old commit written during QC8 S-curves debugging)
  2. Enhance the GE1/1 trigger links reset (mainly wait longer for errors to build up; mostly taken from !309)
  3. Promote the PROM-less errors to genuine errors instead of warnings (this is a back-end issue, not a front-end instability against which the DAQ must be robust)

Related Issue

😬

How Has This Been Tested?

Code builds for all stations; original code from !309 tested for weeks/months in production at P5; modified code tested on the B904 integration area setup.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports