Skip to content
Snippets Groups Projects

Perform S-bit rate scan from high to low thresholds

Merged Laurent Petre requested to merge feature/inverted-sbit-rate-scan into main

Description

As the title says, this merge request aims at performing the S-bit rate scan from high to low thresholds.

Details are in the commit message:

It has been noticed that the VFAT3 S-bit rate can end up in a "locked
up" state. More specifically, when performing the S-bit rate scan from
low to high thresholds, the S-bit rate may not smoothly decreases but
instead drops sharply. The final threshold may or may not be impacted.
Nevertheless, this is considered as abnormal behavior.

This commit swaps the scan direction, scanning from high to low
thresholds. Intense testing on ME0 has revealed a constant and good
performances. No breaking changes in the analysis suite are expected
either.

Related Issue

How Has This Been Tested?

Thoroughly tested on the ME0 stack test beam & QC8 setups.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading