Skip to content

Implement a one-step trimming scan

Laurent Petre requested to merge feature/one-step-trimming into main

Description

As the title says, this MR implements a "one-step trimming scan". While it was long considered to implement a dedicated trimming scan, this MR instead generalizes the S-curve scan parameters to accept a list of 1 trimDAC values (rather than a single one). Consequently, the S-curves RunParams are adjusted to contain the trimDAC value, and the raw-to-histogram tool is enhanced to process such scans. The resulting ROOT file slightly evolved: those scans with a common trimDAC value are saved within a dedicated folder named trimDAC=<value>. This is a breaking change only for the scans with a common trimDAC -- regular S-curves are unaffected.

Related Issue

How Has This Been Tested?

Tested on the GE1/1 integration setup. The expected S-curve histograms can be produced following the designated folder structure.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports