Skip to content

Add and Fix monitoring groups

Dylan Oliver Teague requested to merge feature/gbt_status into develop

Description

Adding GBT (and VFAT soon) functionality to the monitoring suite. Note: this MR is work in progress and based on !5 (closed). When that is merged, this will be changed to merge into the develop branch

Related Issue

This issue has been reference in #37 (closed) but with the testing ongoing at P5, this, plus more functionality is needed

How Has This Been Tested?

Still in testing stages of code. A limitation right now is certain monitorable blocks don't work. This is an observed problem with error handling with RPC requests: if one of the requests in the block fails, the whole block fails and this is done quietly, so it is hard to tell which request caused the problem. Currently, the blocks listed are not implemented:

  • "OH_SCA_TEMP"
  • "OH_SCA_VOLTAGE"
  • "DAQ_TRIGGER_MAIN"
  • "OH_SYSMON"
  • "OH_MAIN"
  • "OH_VFAT_LINK"

The hope with this MR is to resolve these outstanding errors in these blocks so all of them work. As they are fixed, I will be ticking the boxes above to show they have been fixed

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Dylan Oliver Teague

Merge request reports