Skip to content

Fix code formatting issues and enable the CI job that checks it

Louis Moureaux requested to merge bugfix/code-format into develop


When the CI was introduced in !12 (merged) it was requested that the format job (that checks code formatting) be allowed to fail to avoid every pipeline failing because of existing style issues. Over time it appears that additional code with style issues were merged, because checking the job output is too impractical.

This MR fixes all existing styling issues, disables clang-format for external code, and disallows that the format job fails. I also had to add few missing includes to gemrpc headers. I used the opportunity to switch from C stdint.h to C++ cstdint.

Related Issue

Closes #22 (closed) Closes #27 (closed)

How Has This Been Tested?

The CI for this MR is the only test performed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)


  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Louis Moureaux

Merge request reports