Skip to content

Combine all RPC modules in one

Monika Mittal requested to merge feature/combine-rpcmodule into develop

Description

This MR aims at fixing issue #126 (closed) by combining all the RPC modules into one as it creates confusion with the templated RPC framework. Currently, in the cmsgemos code, we have 8 RPC modules:

  • amc
  • calibration_routines
  • daq_monitor
  • expert_tools
  • gbt
  • optohybrid
  • utils
  • vfat3

These are combined into one, named gem_rpc using the module_init function while keeping the separation in the correct namespaces and files. The new file has been created and all the 8 modules and have called and the changes have been made in the build file.

Related Issue

Closes #126 (closed).

How Has This Been Tested?

It is still possible to start a run and take data.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports