Skip to content

Close the standard file descriptors in rpcsvc

Laurent Petre requested to merge bugfix/rpcsvc-stdout into develop

Description

It was noticed that any call to echo via std::system was failing with a return code different than 0. Contrarily to the first thought, the output of std::system must be parsed to provide a clear error message.

After correctly parsing the return code, it was understood that echo failed with the SIGPIPE when rpcsvc was started through a direct SSH call. The fix was to close properly the standard file descriptors when forking rcpsvc.

Using this opportunity to rename the rpcsvc binary to gemrpc in order to avoid confusion.

Related Issue

How Has This Been Tested?

One can still "Initialize" and "Configure" the xDAQ applications.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports