Skip to content

Fix the workloops and timer names

Laurent Petre requested to merge bugfix/timer-and-workloop-names into develop

Description

During the MWGR 5 in 2020, it was noticed that the AMC13 timer was having the same name for all instances. This is an issue that prevents to instantiate more than one AMC13Manager application per xDAQ executive.

This MR aims at rendering unique this timer name as well as reviewing the name of the other timers and workloops throughout the codebase.

The GEMFSM and GEMFSMApplication workloops have been fixed to following the standard naming scheme, i.e. <xDAQ defined prefix>:<class name>:<instance number>:<my name>.

Related Issue

How Has This Been Tested?

Still able to perform transitions between states.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports