Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Corryvreckan Corryvreckan
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 41
    • Issues 41
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CorryvreckanCorryvreckan
  • CorryvreckanCorryvreckan
  • Merge requests
  • !183

WIP: General Broken Lines

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Lennart Huth requested to merge lhuth/corryvreckan:gbltests into master Oct 14, 2019
  • Overview 62
  • Commits 74
  • Pipelines 20
  • Changes 25

This is only a WIP MR adding a general broken line as an optional fit model. There is still a lot of work/clean up required - comments and suggestions are welcome.

New features:

  • General broken lines, ignoring rotations around x/y.
  • "track" class is used as a base class to derive new classes StraightLineTrack and a GBLTrack.
  • Build option BUILD_GBL to use corry on any system.

I am not really happy with the class names and open for suggestions. Currently, rotations are ignored.

There are still missing pieces (Feel free to add toDos here):

  • Test if the new StraightLine implementation provides the same results as the Standard track.
  • Improve naming
  • Implement an state() and direction() function for the GBL
  • Fix the CI problems
  • Provide a test data set
  • Rotations
Edited Oct 14, 2019 by Lennart Huth
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gbltests