Skip to content

JSONWriter Event Separators

Alexander Ferk requested to merge aferk/corryvreckan:jsonWriterEventArray into master

  • Added separators (sub arrays) for each event in the JSONWriter output file.

  • Related to that, I do have a question about the ModuleManager: Due to the placement of https://gitlab.cern.ch/corryvreckan/corryvreckan/-/blob/master/src/core/module/ModuleManager.cpp#L566 it seems that module.run() is called one additional time, e.g. when number_of_events=1000, JSONWriter.run() will be called 1001 times (Events 0 to 1000). Is this intentional or can I fix that by moving the break condition up?

  • Fixed some typos in the git commands in CONTRIBUTING.md.

Merge request reports