Skip to content
Snippets Groups Projects

More Generic MaskCreator

Merged More Generic MaskCreator
maskcreator into master
All threads resolved!
Merged Simon Spannagel requested to merge maskcreator into master
All threads resolved!

This MR adds a new algorithm which is an improved version of the Timepix3MaskCreator as it works for arbitrary detectors and uses the mask_file provided along with the detector in the detector configuration.

Currently it only contains the same mean frequency cut-off approach as the other mask creator, which is okay if the sensor is evenly illuminated. With inhomogeneous beam spot, this will lead to issues and we mght want to consider implementing the local density kernel approach from proteus.

Maybe we could keep both and allow selection of the method.

Merge request reports

Pipeline #341740 passed

Stage: compile
    Stage: format
      Stage: documentation

        Pipeline passed for e5a1d031 on maskcreator

        Approval is optional

        Merged by Simon SpannagelSimon Spannagel 6 years ago (Apr 12, 2018 2:16pm UTC)

        Merge details

        • Changes merged into master with e5a1d031.
        • Deleted the source branch.

        Activity

        Filter activity
        • Approvals
        • Assignees & reviewers
        • Comments (from bots)
        • Comments (from users)
        • Commits & branches
        • Edits
        • Labels
        • Lock status
        • Mentions
        • Merge request status
        • Tracking
      • Simon Spannagel resolved all discussions

        resolved all discussions

      • Simon Spannagel added 31 commits

        added 31 commits

        • da91afa1...eb667cc3 - 25 commits from branch master
        • 88f51f73 - Add autoFit capabilities to EtaCalculation
        • 98452531 - Merge branch 'master' into maskcreator
        • a947527a - MaskCreator: move to using a TH2D for recording occupancy
        • 9eabdfc6 - MaskCreator: prepare for addition of local density estimator: factoring things
        • 2948ae77 - MaskCreator: make local density estimator available
        • e5a1d031 - Update readme

        Compare with previous version

        Toggle commit list
      • Simon Spannagel
        Simon Spannagel @simonspa ·
        Author Owner

        Have added the Proteus approach, still needs testing with some beam-spot-visible data.

      • Simon Spannagel merged

        merged

        • Please register or sign in to reply