Skip to content
Snippets Groups Projects

Analysis efficiency module fix

Merged Younes Otarid requested to merge yotarid/corryvreckan:analysis_efficiency_fix into master
All threads resolved!

Minor fix to failing compilation due to missing header Now making the spatial cut argument of the hasIntercept() function in the AnalysisEfficiency configurable the same way as it is for the AnalysisDUT module.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Simon Spannagel

      Thanks a bunch @yotarid !

      Currently the MacOS compilation is stuck - the reason is that this needs to run on a mac and they are "private" machines standing at CERN. I have added you now to the list of people with access, but you need to activate them in your repository at Settings -> CI/CD -> Runners. There just enable everything at the left column.

      /Simon

  • Younes Otarid added 1 commit

    added 1 commit

    • 3be2a74f - setting default value of spatial cut in hasIntercept() function to previously hard coded value

    Compare with previous version

  • Younes Otarid added 10 commits

    added 10 commits

    • 3be2a74f...a14e3662 - 7 commits from branch corryvreckan:master
    • b547227a - spatial cut argument in hasIntercept() function in AnalysisEfficiency is now configurable
    • 9b7e5ca3 - updating README for AnalysisEfficiency
    • be12f263 - setting default value of spatial cut in hasIntercept() function to previously hard coded value

    Compare with previous version

  • Younes Otarid added 1 commit

    added 1 commit

    Compare with previous version

  • Simon Spannagel approved this merge request

    approved this merge request

  • Simon Spannagel resolved all threads

    resolved all threads

  • Simon Spannagel enabled an automatic merge when the pipeline for a4ae130e succeeds

    enabled an automatic merge when the pipeline for a4ae130e succeeds

  • Simon Spannagel mentioned in commit af7d05fb

    mentioned in commit af7d05fb

  • Please register or sign in to reply
    Loading