Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Corryvreckan Corryvreckan
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 38
    • Issues 38
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 14
    • Merge requests 14
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CorryvreckanCorryvreckan
  • CorryvreckanCorryvreckan
  • Merge requests
  • !53

Enable Compiler Flags: Enable lots of Warnings & Treat Warnings as Errors

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simon Spannagel requested to merge compilerwarnings into master Oct 24, 2018
  • Overview 14
  • Commits 39
  • Pipelines 9
  • Changes 49

This MR enables almost all known compiler warnings and treats them as errors. This should help maintaining a high code quality.

I fixed the errors currently occurring. Since some where shadowed variables and shady casts, we should check with different data sets (ATLASpix, TPX3, CLICpix2) that everything still works as expected.

This currently fixes all Clang errors, some more reported by GCC still need to be tackled - that's why the compilation is failing currently.

Edited Nov 05, 2018 by Simon Spannagel
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: compilerwarnings