Skip to content

OMC3 Fixes

Felix Soubelet requested to merge fixed_coupling_analysis_test into master

Hi,

I have worked with @tpersson to understand and resolve the issues preventing the test script from being successful in the CI. We have identified that the issue came from omc3 missing a few quantities in its coupling output, that were later on needed for the correction calculation.

The necessary fixes have been made and a patch version of omc3, version 0.2.3 is now available from PyPI and the AccPyPI. To go with these fixes I bring here a merge request that adapts the CI setup and coupling correction calculation + its test script.

It might seem like a lot of changes as I have the [bad / good] (make your pick) habit of running a formatter on all my code. The changes all fall into the three following points:

  • Setup and use the appropriate omc3 in CI, directly pip installed;
  • Remove the temporary hack fix from the test script;
  • Make use of the nice omc3 logging tools and timing context.

I'm happy to answer any questions about these changes. Felix.

Merge request reports