Skip to content

PSF integration

Mykhailo Dalchenko requested to merge feature/psf-integration into master

Description

This merge request adds the functionality for the PSF treatment in star cluster reconstruction. The PSF shape is parametrized in polar coordinates with laplace function in φ direction and asymmetric laplace function in R direction. The details of the parametrization are summarized in the issue #13 (closed)

Currently extracted parametrization describes the coma aberration part of the PSF only and doesn't take into account non-ideal mirror focusing. The latter will be treated when a new sim_telarray configuration would become available.

The fitting code is also extended to perform as well fitting in R/φ coordinates (experimental)

TODOs:

  • Pass the parametrization through the configuration files
  • Pass cluster shape ranges through the configuration files
  • Improve error definition (and perhaps implement full likelihood profiling

Related Issue

Closes issue #13 (closed)

How Has This Been Tested?

Run 2007, fit with 2 stars

fit_xy

Run 2009, fit with three stars

fit_xy

Summary by-run fitting:

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Mykhailo Dalchenko

Merge request reports