Clean up errors reported by static analysis
I added the following rule to .cppcheck-suppressions.txt
to stop cppcheck from complaining about GTEST macros:
syntaxError:*Test.cpp
That leaves the following warnings to be checked and cleaned up:
-
78 "check_name": "cppcheck[passedByValue]", Jorge -
30 "check_name": "cppcheck[postfixOperator]", -
21 "check_name": "cppcheck[uninitStructMember]", Michael -
16 "check_name": "cppcheck[useInitializationList]", Vova -
15 "check_name": "cppcheck[uninitDerivedMemberVar]", Michael -
14 "check_name": "cppcheck[arrayIndexOutOfBounds]", Richard -
9 "check_name": "cppcheck[uninitMemberVar]", Michael -
9 "check_name": "cppcheck[syntaxError]", -
7 "check_name": "cppcheck[uninitMemberVarPrivate]", Michael -
6 "check_name": "cppcheck[returnStdMoveLocal]" -
5 "check_name": "cppcheck[virtualCallInConstructor]", Vova -
4 "check_name": "cppcheck[ignoredReturnValue]", -
3 "check_name": "cppcheck[uninitvar]", Michael -
3 "check_name": "cppcheck[selfAssignment]", -
2 "check_name": "cppcheck[uninitDerivedMemberVarPrivate]", Michael -
2 "check_name": "cppcheck[nullPointer]", Vova -
1 "check_name": "cppcheck[unknownMacro]", -
1 "check_name": "cppcheck[throwInNoexceptFunction]", Vova -
1 "check_name": "cppcheck[returnDanglingLifetime]" -
1 "check_name": "cppcheck[nullPointerRedundantCheck]", -
1 "check_name": "cppcheck[missingReturn]", -
1 "check_name": "cppcheck[localMutex]", -
1 "check_name": "cppcheck[invalidPrintfArgType_sint]", -
1 "check_name": "cppcheck[identicalConditionAfterEarlyExit]", -
1 "check_name": "cppcheck[eraseDereference]", -
1 "check_name": "cppcheck[deallocuse]", -
1 "check_name": "cppcheck[toomanyconfigs]"
Edited by Michael Davis