Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
CTA
Manage
Activity
Members
Labels
Plan
Issues
213
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
27
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
cta
CTA
Merge requests
!257
Fix CppCheck code quality issue: "Function parameter 'agentDetails' should be...
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
Fix CppCheck code quality issue: "Function parameter 'agentDetails' should be...
jcamarer-main-patch-12687
into
main
Overview
0
Commits
2
Pipelines
2
Changes
2
Merged
Jorge Camarero Vera
requested to merge
jcamarer-main-patch-12687
into
main
1 year ago
Overview
0
Commits
2
Pipelines
2
Changes
2
Expand
Summary
Requires manual tests in pre-production
References
👍
0
👎
0
Merge request reports
Compare
main
version 1
109dd6f7
1 year ago
main (base)
and
latest version
latest version
751b29d6
2 commits,
1 year ago
version 1
109dd6f7
1 commit,
1 year ago
2 files
+
2
−
2
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
objectstore/GarbageCollector.cpp
+
1
−
1
Options
@@ -149,7 +149,7 @@ void GarbageCollector::checkHeartbeats(log::LogContext & lc) {
}
}
void
GarbageCollector
::
cleanupDeadAgent
(
const
std
::
string
&
address
,
std
::
list
<
log
::
Param
>
agentDetails
,
log
::
LogContext
&
lc
)
{
void
GarbageCollector
::
cleanupDeadAgent
(
const
std
::
string
&
address
,
const
std
::
list
<
log
::
Param
>
&
agentDetails
,
log
::
LogContext
&
lc
)
{
// We detected a dead agent. Try and take ownership of it. It could already be owned
// by another garbage collector.
// To minimize locking, take a lock on the agent and check its ownership first.
Loading