'CMakeLists.txt' (TrkJiveXML-00-01-52)

	* coverity fix
14138 09/07/2014 (Low) Big parameter passed by value :/Tracking/TrkEventCnv/TrkJiveXML/src/TrackRetriever.cxx in function "getResidualPullFromHit"
	* tag as TrkJiveXML-00-01-52

2015-06-16  Juergen Thomas <jpt -at- hep.ph.bham.ac.uk>

  * tag TrkJiveXML-00-01-51
  * updated muon track collection name (data15):

2015-06-09  Jochen Meyer <jomeyer@mail.cern.ch>
   * tag TrkJiveXML-00-01-50
   * addressing coverity defect

2015-03-04 Shaun Roe
	* coverity fix
13555 09/07/2014 (Medium) Logically dead code :/Tracking/TrkEventCnv/TrkJiveXML/src/TrackRetriever.cxx in function "getPerigeeParameters"
	* tag as TrkJiveXML-00-01-49

Tracking/TrkEventCnv/TrkJiveXML/CMakeLists.txt

+################################################################################
+# Package: TrkJiveXML
+################################################################################
+
+# Declare the package name:
+atlas_subdir( TrkJiveXML )
+
+# Declare the package's dependencies:
+atlas_depends_on_subdirs( PUBLIC
+                          Control/AthenaBaseComps
+                          GaudiKernel
+                          Tracking/TrkEvent/TrkParameters
+                          graphics/JiveXML
+                          PRIVATE
+                          Control/DataModel
+                          Control/StoreGate
+                          DetectorDescription/AtlasDetDescr
+                          Reconstruction/Particle
+                          Tracking/TrkEvent/TrkCompetingRIOsOnTrack
+                          Tracking/TrkEvent/TrkEventPrimitives
+                          Tracking/TrkEvent/TrkEventUtils
+                          Tracking/TrkEvent/TrkMeasurementBase
+                          Tracking/TrkEvent/TrkParticleBase
+                          Tracking/TrkEvent/TrkRIO_OnTrack
+                          Tracking/TrkEvent/TrkSegment
+                          Tracking/TrkEvent/TrkTrack
+                          Tracking/TrkEvent/TrkTrackLink
+                          Tracking/TrkEvent/TrkTrackSummary
+                          Tracking/TrkEvent/TrkTruthData
+                          Tracking/TrkEvent/VxVertex
+                          Tracking/TrkTools/TrkToolInterfaces )
+
+# Component(s) in the package:
+atlas_add_component( TrkJiveXML
+                     src/*.cxx
+                     src/components/*.cxx
+                     LINK_LIBRARIES AthenaBaseComps GaudiKernel TrkParameters JiveXMLLib DataModel StoreGateLib SGtests AtlasDetDescr Particle TrkCompetingRIOsOnTrack TrkEventPrimitives TrkEventUtils TrkMeasurementBase TrkParticleBase TrkRIO_OnTrack TrkSegment TrkTrack TrkTrackSummary TrkTruthData VxVertex TrkToolInterfaces )
+
+# Install files from the package:
+atlas_install_headers( TrkJiveXML )
+atlas_install_joboptions( share/*.py )
+

Tracking/TrkEventCnv/TrkJiveXML/TrkJiveXML/SegmentRetriever.h

@@ -33,7 +33,7 @@ namespace JiveXML {
       SegmentRetriever(const std::string& type,const std::string& name,const IInterface* parent);
       
       /// Retrieve all the data
-      virtual StatusCode retrieve(ToolHandle<IFormatTool> FormatTool); 
+      virtual StatusCode retrieve(ToolHandle<IFormatTool> &FormatTool); 
 
       /// Return the name of the data type
       virtual std::string dataTypeName() const { return typeName; };

Tracking/TrkEventCnv/TrkJiveXML/TrkJiveXML/TrackRetriever.h

@@ -67,7 +67,7 @@ namespace JiveXML{
       TrackRetriever(const std::string& type,const std::string& name,const IInterface* parent);
       
       /// Retrieve all the data
-      virtual StatusCode retrieve(ToolHandle<IFormatTool> FormatTool); 
+      virtual StatusCode retrieve(ToolHandle<IFormatTool> &FormatTool); 
 
       /// Return the name of the data type
       virtual std::string dataTypeName() const { return typeName; };

Tracking/TrkEventCnv/TrkJiveXML/TrkJiveXML/VertexRetriever.h

@@ -39,7 +39,7 @@ namespace JiveXML{
       VertexRetriever(const std::string& t,const std::string& n,const IInterface* p);
       
       /// Retrieve all the data
-      virtual StatusCode retrieve(ToolHandle<IFormatTool> FormatTool); 
+      virtual StatusCode retrieve(ToolHandle<IFormatTool> &FormatTool); 
 
       /// Return the name of the data type
       virtual std::string dataTypeName() const { return typeName; };

Tracking/TrkEventCnv/TrkJiveXML/share/TrkJiveXML_DataTypes.py

@@ -19,7 +19,7 @@ theTrackRetriever = JiveXML__TrackRetriever (name = "TrackRetriever")
 ### Switch to the general tracks:
 theTrackRetriever.PriorityTrackCollection = "Tracks"
 ### Select only assorted muon tracks:
-theTrackRetriever.OtherTrackCollections = ["CombinedFitMuonTracks","MuonSpectrometerTracks","ConvertedStacoTracks","ConvertedMuIdCBTracks","CombinedInDetTracks","GSFTracks"]
+theTrackRetriever.OtherTrackCollections = ["CombinedMuonTracks","MuonSpectrometerTracks","ConvertedStacoTracks","ConvertedMuIdCBTracks","CombinedInDetTracks","GSFTracks"]
 ### 
 ### The Event Filter track collections are not written to XML by default.
 ### To write them out, you must uncomment the following line:

Tracking/TrkEventCnv/TrkJiveXML/src/SegmentRetriever.cxx

@@ -35,7 +35,7 @@ namespace JiveXML {
    * - for each segment try to obtain hits and add as multiple collection
    * @param FormatTool the tool that will create formated output from the DataMap
    */
-  StatusCode SegmentRetriever::retrieve(ToolHandle<IFormatTool> FormatTool) {
+  StatusCode SegmentRetriever::retrieve(ToolHandle<IFormatTool> &FormatTool) {
     
     //be verbose
     if (msgLvl(MSG::DEBUG)) msg(MSG::DEBUG) << "Retrieving " << dataTypeName() <<endreq; 

Tracking/TrkEventCnv/TrkJiveXML/src/VertexRetriever.cxx

@@ -150,7 +150,7 @@ namespace JiveXML {
    * - find index in track collection for each track associated with this vertex
    * @param FormatTool the tool that will create formated output from the DataMap
    */
-  StatusCode VertexRetriever::retrieve(ToolHandle<IFormatTool> FormatTool){
+  StatusCode VertexRetriever::retrieve(ToolHandle<IFormatTool> &FormatTool){
 
     //Get an iterator over all vertex collections,
     //return if there are none