Upgrade ckeditor version from dev-full/4.18.x to dev-full/4.20.x

We have been noticing the S2I failing for sites on v9-5-1 with the following error

In Filesystem.php line 330:                                                                                                                                                                   
                                                                                                                                                                                              
  [RuntimeException]                                                                                                                                                                          
  Could not delete /app/vendor/composer/6996dfd3/ckeditor-ckeditor4-releases-                                                                                                                 
  1b303cd/plugins/smiley/images:                                                                                                                                                              
                                                                                                                                                                                              
                                                                                                                                                                                              
Exception trace:                                                                                                                                                                              
  at phar:///usr/bin/composer/src/Composer/Util/Filesystem.php:330                                                                                                                            
 Composer\Util\Filesystem->rmdir() at phar:///usr/bin/composer/src/Composer/Util/Filesystem.php:242                                                                                           
 Composer\Util\Filesystem->removeDirectoryPhp() at phar:///usr/bin/composer/src/Composer/Util/Filesystem.php:132                                                                              
 Composer\Util\Filesystem->removeDirectory() at phar:///usr/bin/composer/src/Composer/Util/Filesystem.php:44                                                                                  
 Composer\Util\Filesystem->remove() at phar:///usr/bin/composer/src/Composer/Downloader/FileDownloader.php:320                                                                                
 Composer\Downloader\FileDownloader->cleanup() at phar:///usr/bin/composer/src/Composer/Downloader/ArchiveDownloader.php:52                                                                   
 Composer\Downloader\ArchiveDownloader->cleanup() at phar:///usr/bin/composer/src/Composer/Downloader/DownloadManager.php:370                                                                 
 Composer\Downloader\DownloadManager->cleanup() at phar:///usr/bin/composer/src/Composer/Installer/LibraryInstaller.php:127                                                                   
 Composer\Installer\LibraryInstaller->cleanup() at phar:///usr/bin/composer/src/Composer/Installer/InstallationManager.php:349                                                                
 Composer\Installer\InstallationManager->Composer\Installer\{closure}() at phar:///usr/bin/composer/src/Composer/Installer/InstallationManager.php:209                                        
 Composer\Installer\InstallationManager->Composer\Installer\{closure}() at phar:///usr/bin/composer/vendor/react/promise/src/Promise.php:245                                                  
 React\Promise\Promise->call() at phar:///usr/bin/composer/vendor/react/promise/src/Promise.php:25                                                                                            
 React\Promise\Promise->__construct() at phar:///usr/bin/composer/src/Composer/Installer/InstallationManager.php:217                                                                          
 Composer\Installer\InstallationManager->Composer\Installer\{closure}() at phar:///usr/bin/composer/src/Composer/Installer/InstallationManager.php:285                                        
 Composer\Installer\InstallationManager->execute() at phar:///usr/bin/composer/src/Composer/Installer.php:759                                                                                 
 Composer\Installer->doInstall() at phar:///usr/bin/composer/src/Composer/Installer.php:588                                                                                                   
 Composer\Installer->doUpdate() at phar:///usr/bin/composer/src/Composer/Installer.php:279                                                                                                    
 Composer\Installer->run() at phar:///usr/bin/composer/src/Composer/Command/UpdateCommand.php:241                                                                                             
 Composer\Command\UpdateCommand->execute() at phar:///usr/bin/composer/vendor/symfony/console/Command/Command.php:298                                                                         
 Symfony\Component\Console\Command\Command->run() at phar:///usr/bin/composer/vendor/symfony/console/Application.php:1015                                                                     
 Symfony\Component\Console\Application->doRunCommand() at phar:///usr/bin/composer/vendor/symfony/console/Application.php:299                                                                 
 Symfony\Component\Console\Application->doRun() at phar:///usr/bin/composer/src/Composer/Console/Application.php:334                                                                          
 Composer\Console\Application->doRun() at phar:///usr/bin/composer/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at phar:///usr/bin/composer/src/Composer/Console/Application.php:130
 Composer\Console\Application->run() at phar:///usr/bin/composer/bin/composer:88
 require() at /usr/bin/composer:29

We have seen this before with v9.4-2/ v9.4-1 but it got resolved in later upgrades. This is most likely a upstream dependency that is causing the inconsistency. After discussing with @fborgesa we wanted to see if upgrading ckeditor fixed the issue, which indeed worked. If this version of the upgrade is acceptable, this will fix failing S2I builds

requested review from @jyde and @fborgesa

This should be perfectly okay since we remain on CKEditor 4.

Thanks for looking into it!

approved this merge request

mentioned in commit 4948a6e6

merged

mentioned in merge request !190 (closed)