Filefield patch with locked versions of required packages

Check list to complete before assigning a MR to someone:

• Link related issues on Related Issues;
• Update documentation;
• Comment relevant changes, why/what lead us to make this change;
• Review at least once you own MR;
• Tests green;

Related issues:

• X

assigned to @ldelpian and @vasvi

assigned to @pkatyaya

Check the box if the site is working properly

test sites:

• https://irsite-testing-fa487b07-vasvi.web.cern.ch
• https://home-d10-fa487b07.web.cern.ch
• https://visits-fa487b07.web.cern.ch
• https://alice-collaboration-7b9474ef.web.cern.ch

added 1 commit

• fa487b07 - bumbed 'drupal/ds' to ~3.21

Compare with previous version

no errors detected on the new site cloned from ir.web.cern.ch  https://irsite-testing-fa487b07-vasvi.web.cern.ch

approved this merge request

marked this merge request as ready

mentioned in merge request !250 (closed)

I'd recommend we release manually on the websites with composers given the last incident.

Can we also validate on a couple of the websites that reported problems and downtime? Eg,

• https://alice-publications.web.cern.ch/
• https://alice-notes.web.cern.ch/
• https://alice-collaboration.web.cern.ch/
• https://beamline-for-schools.web.cern.ch
• https://solvay-education-programme.web.cern.ch
• https://disaster-recovery.web.cern.ch/

unapproved this merge request

requested review from @ldelpian

Hi @vasvi , tilde should not be included, otherwise we're not actually locking up to patch. Please see https://getcomposer.org/doc/articles/versions.md#tilde-version-range-

Using this script https://gitlab.cern.ch/drupal/paas/cern-drupal-distribution/-/blob/v10.1-1/fix-versions.sh?ref_type=heads to fix package versions produces the outputs with the tilde, which is what was done to get the proposed composer JSON file. I will take a look

added 1 commit

• 1aa9ea94 - Update file README.md

Compare with previous version

mentioned in merge request !254 (merged)

added 1 commit

• 6a36228d - Remove tilde

Compare with previous version

added 1 commit

• 7b9474ef - updated "drupal/hook_event_dispatcher" from "4.0.rc1" to "4.0.1",

Compare with previous version

Testing the release on alice collaboration i found the following issue:

TypeError: Drupal\hook_event_dispatcher\HookEventPluginManager::__construct(): Argument #3 ($moduleList) must be of type array, Drupal\hook_event_dispatcher\HookEventDispatcherModuleHandler given, called in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\hook_event_dispatcher\HookEventPluginManager->__construct() (line 35 of /app/web/modules/contrib/hook_event_dispatcher/src/HookEventPluginManager.php).

This is independent from the new release, indeed was blocking me to perform a clone of their site with the current drupal version.

the issue has been resolved here: and included in the new release of the module Hook event dispatcher

I updated the module on the filefieldpatchversion but maybe will be necessary to perform an update before of this module alone followed by drush cr.

Before? Can't be shipped all together (with consequent drush updb and drush cr?

I do not know if it make sense since i do not know how works internally the update of the drupal distribution. I am proposing that because:

1. I tried to create a clone using the filefieldpatch branch and the clone failed due to the error above.
2. I went to the original site, update Hook event dispatcher module there.
3. Cloning now works.

i updated manually the module in the list of sites pointed by carina in the previous comment, they had all the same issue.

approved this merge request

merged

mentioned in commit dcc6191d