Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • D drupalSite-operator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 29
    • Issues 29
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • drupaldrupal
  • paas
  • drupalSite-operator
  • Merge requests
  • !138

Draft: Fix install job creation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Konstantinos Samaras-Tsakiris requested to merge fix-install-job into master Nov 28, 2021
  • Overview 10
  • Commits 4
  • Pipelines 5
  • Changes 4

After changing the install job name in !137 (merged) , I noticed that the new install job was being created for already-installed sites. This is dangerous!

  • Added a check on the Initialized condition before ensuring the install job.
  • Fixed the Initialized condition. It used to be set to false even if the operator simply failed to exec into the pod, which is unintended. Instead, it should be Unknown.
Edited Nov 30, 2021 by Konstantinos Samaras-Tsakiris
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-install-job