Skip to content
Snippets Groups Projects

Toggle objects and overlap removal from runconfig

Merged Frederic Renner requested to merge minimum_selection into master
  • I heavily refactored the minitupleconfig. Its now in order of the objects and has a main() function like structure that branches off for the different objects. This also shows now in a reasonable order the variables when opened with root.
  • The overlap removal is also toggleable and protected for just one large R collection as the overlap removal sequence can only handle one.
  • I changed the config of do_muons a bit which mainly exists to speed up some tests in the CI. Its now a --fast-test flag on the easyjet-ntupler and disables muons and now also overlap removal from the very beginning of the ntupler.
  • harmonize LargeR and VR truth labels with other variables by putting the corresponding prefix in front, e.g. recoUFOjet_antikt10_NOSYS_leadingVRTrackJets_HadronConeExclTruthLabelID

Configurations in the runconfig are added:

# write objects with overlap removal applied
# turning this on you have to decide on one large R jet collection
do_overlap_removal: false
# which objets to write
write_small_R_jets: true
write_large_R_Topo_jets: true
write_large_R_UFO_jets: true
write_electrons: true
write_photons: true
write_muons: true
# is MC protected
write_truth_small_R_jets: true
write_truth_large_R_jets: true
write_truth_higgs: true
Edited by Frederic Renner

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Frederic Renner resolved all threads

    resolved all threads

  • Dan Guest
  • added 1 commit

    Compare with previous version

  • Frederic Renner changed title from Draft: jets only config to draft: enable objects from runconfig

    changed title from Draft: jets only config to draft: enable objects from runconfig

  • Frederic Renner changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • I guess you can also avoid the _OR_ list of objects (as an option)?

  • Frederic Renner added 10 commits

    added 10 commits

    Compare with previous version

  • Frederic Renner marked this merge request as ready

    marked this merge request as ready

  • Frederic Renner changed title from draft: enable objects from runconfig to Toggle objects and overlap removal from runconfig

    changed title from draft: enable objects from runconfig to Toggle objects and overlap removal from runconfig

  • Frederic Renner changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • Frederic Renner changed the description

    changed the description

  • Frederic Renner added 5 commits

    added 5 commits

    Compare with previous version

  • Frederic Renner resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Frederic Renner changed the description

    changed the description

  • Frederic Renner added 5 commits

    added 5 commits

    Compare with previous version

  • Frederic Renner changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • Frederic Renner changed the description

    changed the description

  • Dan Guest
  • Dan Guest
    • Resolved by Frederic Renner

      Thanks for accommodating the --fast-test option here, I'm mainly commenting on that since the rest of this looks pretty good (assuming you did a quick look at the output files and made sure they have about the same branches).

      I wonder if we should just make --fast-test option disable the overlap removal and muon flags directly, right after the flags are defined, rather than accessing it much deeper down the call stack. Will this give the same behavior?

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Dan Guest
  • Dan Guest
  • I think this is great! One comment that isn't super important. I guess we should ping others to take a look given the amount of code it touches but I think we should merge this soon if there aren't any urgent objections.

  • Dan Guest approved this merge request

    approved this merge request

  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading