Skip to content
Snippets Groups Projects
Select Git revision
0 results
Search by author
  • Any Author
0 authors
  1. Mar 24, 2018
  3. Mar 12, 2018
    • Will Leight's avatar
      Fix for ATR-16605, round two · a8b711ed
      Will Leight authored 
      As discussed in !2959, a bug in the extrapolator was in rare cases causing thousands of scatterers to be added to a track.
Thanks to Peter Kluit, we believe that we have now tracked this down to a bug in the STEP_Propagator.
The propagator was getting stuck in a volume and iterating forward in steps of 1-10 um, adding a scatterer each time.
At the time, we implemented a "fix" that simply aborted the track-finding when more than 1000 scatterers were found on a track.
Now, the underlying issue should finally be resolved.
It appears that the problem was occurring when the propagator found two solutions from the starting surface, the first of which was trivial and the second of which gave a negative distance estimate.
In this case, the propagator would automatically flip direction, bringing it back almost to the starting point, where it would add a scatterer.
Then the process would repeat thousands of times, until it got far enough away from the start position that there was no second solution, or one with a postive distance estimate.
By identifying these cases and rejecting their negative-distance second solutions, this problem is avoided.
Given the rarity of this problem, FT0 tests naturally show no violation, results are available at /afs/cern.ch/work/w/wleight/public/MuonSW/tooManyScatterers/RunTier0Tests.log


Former-commit-id: 0c1c0d3b0c6bd977208a58a2fc9c9062d4516c7c
      a8b711ed
  5. Mar 01, 2018
    • Vincent Pascuzzi's avatar
      Fix use of smart pointers in `Trk::RectangularSegmentation' · e60b7752
      Vincent Pascuzzi authored 
      The previous commit to this class incorrectly used smart pointers,
specifically, their ownership was not released. Moreover, the wrapped
objects were initialised incorrectly, leading to the same
`Trk::PlaneSurface' being duplicated, filling the vector with the same
surface.

Although it appears the owning objects free memory, we play it safe by
keeping the smart pointers here, as opposed to resorting back to raw
ones.


Former-commit-id: d79f604018172cc9533a35c453d05a589554a346
      e60b7752
  7. Feb 20, 2018
  9. Feb 09, 2018
  11. Jan 09, 2018
  13. Dec 21, 2017
  15. Dec 12, 2017
  17. Dec 10, 2017
  19. Dec 07, 2017
  21. Nov 30, 2017
  23. Nov 24, 2017
  25. Nov 20, 2017
  27. Nov 17, 2017
  29. Nov 13, 2017
  31. Nov 10, 2017
  33. Nov 09, 2017
  35. Nov 06, 2017
    • Will Leight's avatar
      Further fixes for ATLASRECTS-3796 · acd608e3
      Will Leight authored 
      The original fix for missing truthParticleLinks implicitly assumed that the xAOD::TrackParticle always had an attached truthParticleLink.
In turn, the code for adding the truthParticleLink to the xAOD::TrackParticle implicitly assumed that the trackParticle always had an attached trackLink().
However, recent studies on 21.0-mc16d by Jovan seem to indicate that at least one of these assumptions is violated.
This fix should hopefully ensure that a dummy truthParticleLink is always added to the trackParticle and the Muon object no matter what.


Former-commit-id: 45a1b270
      acd608e3
    • John Chapman's avatar
      Remove use of PyG4AtlasAlg in job options · 8663c404
      John Chapman authored 
      `PyG4AtlasAlg` is now obsolete, so all usage should be removed from
job options. Also updated some other obsolete simulation syntax in
the affected job options files.


Former-commit-id: c29bd1c4dd5c56655c018b7151426f76097fdbc3
      8663c404
  37. Nov 04, 2017
    • Will Leight's avatar
      Fix for ATR-16605 · edcb11fe
      Will Leight authored 
      The standalone muon track fit uses the GlobalChi2Fitter (unlike the combined track fit which uses the iPatFitter).
In rare cases (and only when the GlobalChi2Fitter is used for muons) the call to obtain the list of downstream scatterers from the extrapolator gives bad results.
The extrapolator returns a list of thousands of scatterers, which is clearly wrong.
This results in the fitter trying to solve a thousands by thousands matrix, which then leads to trigger timeouts.
To avoid this behavior, a configurable setting is added to the GlobalChi2Fitter to check for the return of over 1000 scatterers and simply quit if so.
It is false by default, but set to true in the muon instance of GlobalChi2Fitter, configured in MuonRecTools.py.
The underlying cause of this problem should probably be studied by an extrapolator expert, but for now this will get rid of the timeouts.
Results of the trig tests are available at /afs/cern.ch/work/w/wleight/public/MuonSW/ATR-16605/.


Former-commit-id: ad377d31
      edcb11fe
  39. Nov 02, 2017