Skip to content
Snippets Groups Projects
  1. Sep 12, 2018
    • Steven Schramm's avatar
      Fix small memory leak · e8acf646
      Steven Schramm authored
      One of the sub-tools of the jet calibration tool was not properly
      deleted, so multiple tool usage led to a small memory leak.  This
      has been fixed.
      
      
      Former-commit-id: 9f56f66a9e0cb5d3e0b725b924721e18829af02c
      e8acf646
  2. Sep 11, 2018
    • Steven Schramm's avatar
      Bugfix and optimization for new JER smearing · 7c7657a3
      Steven Schramm authored
      The JetCalibTools implementation has sub-optimal CPU performance,
      namely it was creating projections from a TH2 each time it was called
      due to the need to interpolate only in one dimension.  This has now
      been fixed by projecting and caching all bins once during the
      initialize() method and then using them directly.  The speedup
      is considerable and may be somehow also related to a problem observed
      on the PATHelp list.  This is not entirely clear, as the underlying
      cause may EventLoop related and just be hidden due to the
      substantial CPU reduction from this update.  Either way, this is a
      useful CPU reduction and if the other problem re-appears in more
      intensive uses, then it can be further investigated.
      
      In addition, the process of debugging this slowdown led to the
      discovery of a bug in the new resolution recommendations.  If the
      tool was configured for GeV inputs, everything was fine.  However,
      if the tool was configured for MeV inputs, then the tool was using
      the wrong values for smearing.  The impact of this mistake was
      strongly suppressed due to only the difference between data and MC
      being applied (and this difference is roughly constant with pT),
      but it is still a non-negligible effect.
      
      
      Former-commit-id: 9e73f2c5bce8c7ed0348f65f6125d87fbd4e086e
      7c7657a3
  3. Sep 10, 2018
  4. Sep 09, 2018
  5. Sep 08, 2018
  6. Sep 07, 2018
  7. Sep 06, 2018
Loading