EvtId and EvtPDL improvements
This is another chunk cherry-picked from !22 (merged). It includes the modernisation of EvtId plus the conversion of EvtPDL into a thread-local singleton.
Merge request reports
Activity
assigned to @fabudine
These changes were developed together with @tlatham, so we need the review from @jback and/or @kreps.
Edited by Fernando Jesus Abudinen Gallegomentioned in commit 626cab4a
added 2 commits
Thanks @jback and @kreps for the review. I will wait for @tlatham to check whether there is something else we want to add to this MR. Once I get his Ok, I will land D128.
Edited by Fernando Jesus Abudinen Gallego55 45 << "Could not open:" << fname << "EvtPDL" << endl; 56 46 return; 57 47 } 58 readPDT( pdtIn ); 48 getInstance().readPDT( pdtIn ); Ok, I removed this line and ran various tests, which gave the exact same output as in master. If I grep for
read(
it seems that the functionEvtPDL::read
is actually not used anywhere?Edited by Fernando Jesus Abudinen Gallegochanged this line in version 3 of the diff
If we don't think we need the
EvtPDL::read
function then we could remove it. However, we need to be careful since this is the kind of function that might be used externally by experiment frameworks.However, if we keep the function, the line should stay, but as it was originally, i.e. reverting the addition of
getInstance().
at the start.Edited by Thomas Latham
mentioned in commit f180c746
added 6 commits
Toggle commit list