fix tracker module eta index calculation

This MR fixes the tracker module mapping such that it matches the desired mapping found on page 4 here. Where this quote from Dave then explains how the eta and phi indices should be calculated:

It is a rule in the offline software that indices increase in the same direction as the global coordinates in a right-handed system with +z downstream and +y (nearly) opposite gravity. So the eta = -1 corresponds to negative X (to the right, when looking downstream), and eta = +1 corresponds to positive X (to the left, when looking downstream). Similarly, the phi module index increases in the upward vertical direction, with phi = 0 closest to the floor.

This results in the correct mapping (module,phi,eta) being: (0,3,1) (1,2,1) (2,1,1) (3,0,1) (4,3,-1) (5,2,-1) (6,1,-1) (7,0,-1)

The old code was calculating the eta index wrong and was thus flipping the tracker modules over X and inverting the X direction of the tracker. It was also first converting the online module number to an offline module number (a relic of how the code worked years ago) before calculating the phi and eta indices. In this MR, i remove the useless and confusing conversion and just calculate the indices directly from the online module number.

Tracker/TrackerEventCnv/TrackerByteStream/src/TrackerDataDecoderTool.cxx

@@ -197,8 +197,6 @@ TrackerDataDecoderTool::convert(const DAQFormats::EventFull* re,
           //   continue;
           // }
           ATH_MSG_DEBUG("Processing online module #" << onlineModuleID);
-          // Offline module number
-          uint32_t module = m_moduleMap[onlineModuleID];
           size_t chipIndex{0};
           for (auto hitVector : sctEvent->GetHits())
           {
@@ -218,8 +216,8 @@ TrackerDataDecoderTool::convert(const DAQFormats::EventFull* re,
                 uint32_t hitPattern  = hit.second;
                 if (hitMode == HitMode::EDGE && (((hitPattern & 0x2) == 0 ) || ((hitPattern & 0x4) != 0) ) ) continue; // 01X
                 if (hitMode == HitMode::LEVEL && ((hitPattern & 0x2) == 0)) continue; // X1X
-                int phiModule = module % 4; // 0 to 3 from bottom to top
-                int etaModule = -1 + 2*((module%2 + module/4) % 2); // -1 or +1
+                int phiModule = 3 - (onlineModuleID % 4); // 0 to 3 from bottom to top: (module#,Phi#) =  (0,3),(1,2),(2,1),(3,0),(4,3),(5,2),(6,1),(7,0)
+                int etaModule = -2*(onlineModuleID/4) + 1; // eta = +1 for modules 0,1,2,3 and eta = -1 for 4,5,6,7 
                 // ATH_MSG_DEBUG("Getting wafer_id for station, plane, phi, eta, side = " << station << " " << plane << " " << phiModule << " " << etaModule << " " << side);
                 Identifier id = m_sctID->wafer_id(station, plane, phiModule, etaModule, side);
                 IdentifierHash waferHash = m_sctID->wafer_hash(id);  // this will be the collection number in the container