Merge branch 'gcc9.AthContainers-20181211' into 'master'

AthContainers: Fix gcc9 warnings.

See merge request atlas/athena!16679

Control/AthContainers/AthContainers/ViewVectorBase.h

 // This file's extension implies that it's C, but it's really -*- C++ -*-.
 
 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id$
@@ -38,7 +38,7 @@ class ViewVectorBase
 {
 public:
   /// Destructor.
-  virtual ~ViewVectorBase();
+  virtual ~ViewVectorBase() = default;
 
 
   /**

Control/AthContainers/AthContainers/ViewVectorBase.icc

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id$
@@ -52,15 +52,6 @@ SG::AuxVectorData* getContainer (T* p)
 namespace SG {
 
 
-/**
- * @brief Destructor.
- */
-inline
-ViewVectorBase::~ViewVectorBase()
-{
-}
-
-
 /**
  * @brief Clear the persistent data.
  */

Control/AthContainers/test/DataVector_test.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
 */
 
 
@@ -77,7 +77,7 @@ class FluffContainer : public DataVector<DerivedFluff>
 {
 public:
   FluffContainer() : DataVector<DerivedFluff>() { };
-  virtual ~FluffContainer() {}
+  virtual ~FluffContainer() = default;
 };
 
 

Control/AthContainers/test/DataVector_test.icc

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2018 CERN for the benefit of the ATLAS collaboration
 */
 
 // $Id$
@@ -117,6 +117,8 @@ void check_dtor_log(int a=-1,int b=-1,int c=-1,int d=-1, int e=-1, int f=-1)
 struct AA
 {
   AA (int the_x=0): x(the_x) {}
+  AA (const AA&) = default;
+  AA& operator= (const AA&) = default;
   ~AA() { dtor_log.push_back (x); }
   int x;
   bool operator< (const AA& other) const { return x < other.x; }
@@ -198,7 +200,8 @@ CLASS_DEF( DataVector<Q> , 9886 , 1 )
 struct AAux : public SG::AuxElement
 {
   AAux (int the_x=0) : x(the_x)  {   }
-  //AAux (const AAux& other) : SG::AuxElement(other), x(other.x) {}
+  AAux (const AAux& other) = default;
+  AAux& operator= (const AAux& other) = default;
   virtual ~AAux() { dtor_log.push_back (x); }
   int x;
   bool operator< (const AAux& other) const { return x < other.x; }