Skip to content

Start using common tools for histogramming

Mauro Dinardo requested to merge (removed):chipPolymorphism into chipContainer

Dear Fabio, we started to use the common tools for histogramming. Please check what we did carefully and let us know if it's ok. In particular:

  • we added a RD53HistogramsBase.h base class
  • We do not inherit from DQMHistogramBase.h because it's not strictly needed
  • We modified RootContainerFactory.h
  • We added the templated class HistContainer.h -> if you want you can get rid of TH1FContainer and TH2FContainer
  • We found a bug in https://gitlab.cern.ch/cmsinnertracker/Ph2_ACF/blob/chipPolymorphism/HWDescription/Chip.cc#L83
  • We found a bug in https://gitlab.cern.ch/cmsinnertracker/Ph2_ACF/blob/chipPolymorphism/tools/Tool.cc#L437

Please let us know. Once we settle this down, we will proceed to integrate also the other calibrations.

  • Mauro and Alkis.

Merge request reports