Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Gaudi
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Gaudi
Gaudi
Compare revisions
9c38c32c02cd192f9d246f509c7fff7c80e08d07 to 58146ecb829539a555640266a0ae08b1e023838d
Compare revisions
Changes are shown as if the
source
revision was being merged into the
target
revision.
Learn more about comparing revisions.
Source
gaudi/Gaudi
Select target project
No results found
58146ecb829539a555640266a0ae08b1e023838d
Select Git revision
Swap
Target
gaudi/Gaudi
Select target project
holau/Gaudi
dmagdali/Gaudi
pmunozpa/Gaudi
ssottoco/Gaudi
cvarni/Gaudi
mafila/Gaudi
admorris/Gaudi
staider/Gaudi
gunther/Gaudi
bstanisl/Gaudi
jtorasso/Gaudi
wochung/Gaudi
mveghel/Gaudi
averbyts/Gaudi
dguest/Gaudi
alboyer/Gaudi
dkonst/Gaudi
jcarcell/Gaudi
elmsheus/Gaudi
hpxgaudi/Gaudi
ganis/Gaudi
tadej/Gaudi
hahansen/Gaudi
juesseiv/Gaudi
imjelde/gaudida
jheuel/Gaudi
mimazure/Gaudi
masato/Gaudi
dcasperfaser/Gaudi
faser/offline/Gaudi
axu/Gaudi
sailer/Gaudi
amete/Gaudi
ponyisi/Gaudi
vavolkl/Gaudi
mstahl/Gaudi
wlampl/Gaudi
kreczko/Gaudi
emoyse/Gaudi
dhynds/Gaudi
sstahl/Gaudi
rcurrie/Gaudi
smh/Gaudi
valassi/Gaudi
bwynne/Gaudi_gaudi
abarton/Gaudi
tsulaia/gaudigaudi
mnowak/Gaudi
roiser/Gaudi
merrenst/Gaudi
mato/Gaudi
christos/Gaudi
goetz/Gaudi
goetz/AtlasGaudi
tsulaia/atlasgaudi
olupton/Gaudi
pseyfert/Gaudi
graemes/Gaudi
gianelle/Gaudi
akraszna/AtlasGaudi
cattanem/Gaudi
skluth/Gaudi
will/Gaudi
ssnyder/Gaudi
agonzale/Gaudi
leggett/AtlasGaudi
apearce/Gaudi
mnowak/Gaudi-ORIG
fwinkl/AtlasGaudi
bwynne/Gaudi_atlas
chamont/Gaudi
rmatev/Gaudi
lhcb/Gaudi
atlas/Gaudi
akraszna/GaudiGaudi
fwinkl/Gaudi
jonrob/Gaudi
azaborow/Gaudi
clemenci/Gaudi
hgraslan/Gaudi
srimanob/Gaudi
graven/Gaudi
hegner/Gaudi
gaudi/Gaudi
84 results
9c38c32c02cd192f9d246f509c7fff7c80e08d07
Select Git revision
Show changes
Only incoming changes from source
Include changes to target since source was created
Compare
Commits on Source (2)
Fix ToolHandle names
· 77d1089f
Charles Leggett
authored
7 years ago
and
Marco Clemencic
committed
7 years ago
77d1089f
Use tool type as default name for auto registered ToolHandles (mr !535)
· 58146ecb
Marco Clemencic
authored
7 years ago
58146ecb
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
GaudiExamples/src/AlgTools/MyGaudiAlgorithm.h
+4
-4
4 additions, 4 deletions
GaudiExamples/src/AlgTools/MyGaudiAlgorithm.h
GaudiKernel/GaudiKernel/ToolHandle.h
+11
-12
11 additions, 12 deletions
GaudiKernel/GaudiKernel/ToolHandle.h
with
15 additions
and
16 deletions
GaudiExamples/src/AlgTools/MyGaudiAlgorithm.h
View file @
58146ecb
...
...
@@ -43,12 +43,12 @@ private:
ToolHandle
<
IMyTool
>
m_legacyToolHandle
{
"MyTool/LegacyToolHandle"
,
this
};
ToolHandle
<
IMyTool
>
m_myPrivToolHandle
{
this
,
"PrivToolHandle"
,
"MyTool"
};
PublicToolHandle
<
IMyTool
>
m_myPubToolHandle
{
this
,
"PubToolHandle"
,
"MyTool"
};
ToolHandle
<
IMyTool
>
m_myPrivToolHandle
{
this
,
"PrivToolHandle"
,
"MyTool
/PrivToolHandle
"
};
PublicToolHandle
<
IMyTool
>
m_myPubToolHandle
{
this
,
"PubToolHandle"
,
"MyTool
/PubToolHandle
"
};
PublicToolHandle
<
IAlgTool
>
m_myGenericToolHandle
{
this
,
"GenericToolHandle"
,
"MyTool"
};
PublicToolHandle
<
IAlgTool
>
m_myGenericToolHandle
{
this
,
"GenericToolHandle"
,
"MyTool
/GenericToolHandle
"
};
ToolHandle
<
IAlgTool
>
m_myUnusedToolHandle
{
this
,
"UnusedToolHandle"
,
"TestToolFailing"
};
ToolHandle
<
IAlgTool
>
m_myUnusedToolHandle
{
this
,
"UnusedToolHandle"
,
"TestToolFailing
/UnusedToolHandle
"
};
ToolHandle
<
IMyTool
>
m_undefinedToolHandle
{
this
};
ToolHandle
<
IMyTool
>
m_invalidToolHandle
{
this
,
"InvalidToolHandle"
,
"TestToolFailing"
};
...
...
This diff is collapsed.
Click to expand it.
GaudiKernel/GaudiKernel/ToolHandle.h
View file @
58146ecb
...
...
@@ -187,20 +187,20 @@ public:
{
}
/// Autodeclaring constructor with property
n
ame, tool type/name and documentation.
/// Autodeclaring constructor with property
propN
ame, tool type/name and documentation.
/// @note the use std::enable_if is required to avoid ambiguities
template
<
class
OWNER
,
typename
=
std
::
enable_if_t
<
std
::
is_base_of
<
IProperty
,
OWNER
>
::
value
>>
inline
ToolHandle
(
OWNER
*
owner
,
std
::
string
name
,
std
::
string
toolType
,
std
::
string
doc
=
""
)
:
ToolHandle
(
owner
)
inline
ToolHandle
(
OWNER
*
owner
,
std
::
string
propName
,
std
::
string
toolType
,
std
::
string
doc
=
""
)
:
ToolHandle
(
owner
)
{
// convert name and type to a valid type/name string
// - if type does not contain '/' use type/
nam
e
// - if type does not contain '/' use type/
typ
e
// - otherwise type is already a type/name string
if
(
!
toolType
.
empty
()
and
toolType
.
find
(
'/'
)
==
std
::
string
::
npos
)
{
toolType
+=
'/'
;
toolType
+=
name
;
toolType
+=
'/'
+
toolType
;
}
owner
->
declareTool
(
*
this
,
std
::
move
(
toolType
)
).
ignore
();
auto
p
=
owner
->
OWNER
::
PropertyHolderImpl
::
declareProperty
(
std
::
move
(
n
ame
),
*
this
,
std
::
move
(
doc
)
);
auto
p
=
owner
->
OWNER
::
PropertyHolderImpl
::
declareProperty
(
std
::
move
(
propN
ame
),
*
this
,
std
::
move
(
doc
)
);
p
->
template
setOwnerType
<
OWNER
>();
}
...
...
@@ -316,21 +316,20 @@ public:
{
}
/// Autodeclaring constructor with property
n
ame, tool type/name and documentation.
/// Autodeclaring constructor with property
propN
ame, tool type/name and documentation.
/// @note the use std::enable_if is required to avoid ambiguities
template
<
class
OWNER
,
typename
=
typename
std
::
enable_if
<
std
::
is_base_of
<
IProperty
,
OWNER
>
::
value
>::
type
>
inline
PublicToolHandle
(
OWNER
*
owner
,
std
::
string
n
ame
,
std
::
string
toolType
,
std
::
string
doc
=
""
)
inline
PublicToolHandle
(
OWNER
*
owner
,
std
::
string
propN
ame
,
std
::
string
toolType
,
std
::
string
doc
=
""
)
:
PublicToolHandle
()
{
// convert name and type to a valid type/name string
// - if type does not contain '/' use type/
nam
e
// - if type does not contain '/' use type/
typ
e
// - otherwise type is already a type/name string
if
(
!
toolType
.
empty
()
and
toolType
.
find
(
'/'
)
==
std
::
string
::
npos
)
{
toolType
+=
'/'
;
toolType
+=
name
;
toolType
+=
'/'
+
toolType
;
}
owner
->
declareTool
(
*
this
,
std
::
move
(
toolType
)
).
ignore
();
auto
p
=
owner
->
OWNER
::
PropertyHolderImpl
::
declareProperty
(
std
::
move
(
n
ame
),
*
this
,
std
::
move
(
doc
)
);
auto
p
=
owner
->
OWNER
::
PropertyHolderImpl
::
declareProperty
(
std
::
move
(
propN
ame
),
*
this
,
std
::
move
(
doc
)
);
p
->
template
setOwnerType
<
OWNER
>();
}
};
...
...
This diff is collapsed.
Click to expand it.