ToolSvc ignores property with unknown names in JobOptionsSvc
With the last gaudi update in athena the following behavior change appeared: Up to now when creating a tool through the ToolSvc it would generate an error if there was any property configured in the JobOptionsSvc that did not exist for the tool. With the latest version this is silently ignored.
This is one of the test cases that got tripped up by the latest change:
TEST (AnaToolHandleTest, DISABLED_athena_job_options_misspelled)
{
std::string name = makeUniqueName();
ServiceHandle<IJobOptionsSvc> joSvc("JobOptionsSvc","");
ASSERT_SUCCESS (joSvc->addPropertyToCatalogue ("ToolSvc." + name, StringProperty("invalid", "57")));
AnaToolHandle<IUnitTestTool1> handle ("asg::UnitTestTool1/" + name);
ASSERT_TRUE (handle.isUserConfigured());
ASSERT_FAILURE (handle.initialize()); // <-- this reports SUCCESS instead of FAILURE
}
Which should be equivalent to this (didn't check this one against the previous version):
TEST (AnaToolHandleTest, athena_job_options_misspelled_basic)
{
std::string name = "MyTool";
ServiceHandle<IJobOptionsSvc> joSvc("JobOptionsSvc","");
ASSERT_SUCCESS (joSvc->addPropertyToCatalogue ("ToolSvc." + name, StringProperty("invalid", "57")));
ToolHandle<IUnitTestTool1> handle ("asg::UnitTestTool1/" + name);
ASSERT_FAILURE (handle.retrieve()); // <-- this reports SUCCESS instead of FAILURE
}
cc @leggett