Skip to content

Prevent operator== on properties of floating point types

The following discussion from !1490 (merged) should be addressed:

  • @sponce started a discussion:

    == on Properties is as evil as the one on floats. It's true that C++ allows it on floats but the whole point of all this is to de facto forbid it as any usage will result in a Warning that -Werror will convert to error and prevent you to compile. So why not forbid it simply for Properties where it's possible ?

    And yes, we may have to wait that Atlas fixes the problems it raises. But see theses problems as opportunities, as each of them is a potential bias in the current physics results ! Now practically, if we can have part of the current MR included now and only !1490 (3f02752e) waiting for fixes on the Atlas side, it sound like a very nice path forward indeed.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information