Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
Gaudi
Gaudi
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 83
    • Issues 83
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 34
    • Merge Requests 34
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • Gaudi
  • GaudiGaudi
  • Merge Requests
  • !1056

Open
Opened Mar 31, 2020 by Niklas Stefan Nolte@nnolte🔥Developer
  • Report abuse
Report abuse

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "NN_onevirtualless" "origin/NN_onevirtualless"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "master"
git merge --no-ff "NN_onevirtualless"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

WIP crtp vs virtual

  • Overview 1
  • Commits 2
  • Pipelines 2
  • Changes 9

avoid virtual in operator() in transformer/consumer/producer by using crtp.
WIP cause Merging/SplittingTransformer are still on virtual operator() implementations, no conceptual problem i think, but i first wanted to check with other people.
what do you think @graven ?

Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
Reference: gaudi/Gaudi!1056
Source branch: NN_onevirtualless