Skip to content

Minor fixes for Clang 10 build, adapt BinaryTagUtils to allow compiler version >10

Christoph Hasse requested to merge chasse/Gaudi:clang10_warnings into master

This MR includes minor fixes for building Gaudi with clang10

  • Add an ampersand to auto in two range based for loops. Spotted by clang warnings in a lhcb nightly.
  • Adjusted the getProperty function in Bootstrap.cpp as there is a call of the sort
  • Adapt BinaryTagUtils to allow double digits in compiler version. This is a quick fix that specially handles a version of the format 1x. so should work up to clang or gcc 19.
    But AFAIK this file will become obsolete once the transition to the new CMake is done, so 🤞 that is over before clang19 comes out 😄
return prop->getProperty( name ).toString().c_str()

This gets flagged by clang as we are returning a char const* to the temporary std::string returned by toString().

cc @clemenci

Edited by Christoph Hasse

Merge request reports