Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Gaudi Gaudi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 121
    • Issues 121
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 34
    • Merge requests 34
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GaudiGaudi
  • GaudiGaudi
  • Merge requests
  • !1241

"Fixed" scan_dict_deps.py for not including directories

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sebastien Ponce requested to merge sponce_scan_dict_deps into master Aug 05, 2021
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

This was discovered thanks to a name collision between Eigen and DD4hep, Eigen having an header file named "Core" (with no extension indeed) and DD4hep a directory with same name. DD4hep happened to come first in the dependency list and thus the directort was used...

Note that this reveal a deeper problem in the scanning made by this tool : no scoping and thus no cleaning of the list of directories when going to next file. This is the actual root of the problem that lead to DD4hep being first in the dependency list

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sponce_scan_dict_deps