Skip to content
Snippets Groups Projects

C++20 fixes

Merged Andre Sailer requested to merge sailer/Gaudi:c++20Fixes into master

Fix compilation with gcc13 / c++20 , ROOT 6.28.04 (LCG dev4), fmtlib 10.0.0

  • use fmt::runtime where needed (with a hack to still work with fmtlib < 8)
  • avoid implicit capture of this in lambdas via [=]
  • fix comparison between Gaudi::Property<std::string> and const char*
  • hide std::source_location to cling

Closes #266 (closed)

Edited by Marco Clemencic

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Andre Sailer
  • Andre Sailer added 10 commits

    added 10 commits

    • 38ea1b8b - PluginService: root clang does has source_location in experimental
    • 437797b9 - ChronoEntity: these need to be constepxr
    • 3154a4cf - KeyedObjectManager: no template thing in the d'tor
    • bba2e606 - Allocator: fix 'template-id not allowed for destructor'
    • 3b9e8b95 - Catalog: wrong fmt use??? (no idea but it compiles now...)
    • e4b72a41 - HistogramArray: use fmt:runtime
    • 5bbe9155 - genconf: use fmt::runtime
    • 3d683ffb - MessageSvcSink: use fmt::runtime
    • e33b9ad5 - multiple: switch operands in operator== because it didn't exist the other way around
    • f94abcdb - MessageSvcSink: this fails to compile

    Compare with previous version

  • Marco Clemencic added 1 commit

    added 1 commit

    • c8164149 - Fix custom formatter for JSON in MessageSvcSink

    Compare with previous version

  • Marco Clemencic changed milestone to %v36r13

    changed milestone to %v36r13

  • Marco Clemencic added 1 commit

    added 1 commit

    • fd500e24 - fix warnings about 'this' captured in lambdas via [=]

    Compare with previous version

  • Marco Clemencic added 1 commit

    added 1 commit

    • a9a4cad9 - Fix compilation with fmtlib < 8

    Compare with previous version

  • Marco Clemencic resolved all threads

    resolved all threads

  • mentioned in issue #268 (closed)

  • Edited by Software for LHCb
  • Marco Clemencic approved this merge request

    approved this merge request

  • Marco Clemencic changed title from C++20 fixes for #266 to C++20 fixes

    changed title from C++20 fixes for #266 to C++20 fixes

  • Marco Clemencic changed the description

    changed the description

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading