Skip to content

Use the value of m_scheduledStop instead of simply ignoring it in HiveSlimEventLoopMgr.cpp

Juan Miguel Carceller requested to merge jcarcell/Gaudi:scheduled-stop into master

Currently m_scheduledStop is never checked for so if you schedule a stop nothing will happen. I have to double check that there aren't any warnings when running (I remember seeing some when draining) but at least this works for me. Would it be interesting to add a test?

Edit: I added a test for checking it actually stops. Without the fix, there will be multiple lines like this one:

StopperAlg           INFO scheduling a event processing stop....

as the algorithm is scheduling a stop every time it runs but it's doing nothing. After the fix, this line only appears once.

There is an error in the logs that I haven't fixed yet:

HiveSlimEventLo...  ERROR Detected nullptr ctxt before clearing WB!

seems to be harmless but it probably shouldn't be there.

Closes #288

Edited by Marco Clemencic

Merge request reports