Skip to content

Fix node properties in `PrecedenceGraph`, update precedence related scripts

Mateusz Jakub Fila requested to merge mafila/Gaudi:precedence_update into master

Fixes to problems encountered experimenting with control flow information from PrecedenceSvc

  • update hivetimeline.py script to python3
  • fix getCriticalPath.py script expecting different node property names than used in PrecedenceSvc
  • fix PrecedenceSvc and PrecedenceGraph using wrong control flow node properties:
    • Properties 'Inverted' and 'AllPass' were assigned to algorithm nodes even though the properties are not used in the algorithms. Default values (false, false) were always used. The 'Inverted' and 'AllPass' were removed from the algorithms nodes and logic simplified
    • Decision hub node property 'Inverted' was not used when writing precedence rules to graphml.

The last point is relevant for exporting the control flow information to text format, since now the correct node properties will be exported

Edited by Mateusz Jakub Fila

Merge request reports