Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Gaudi Gaudi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 104
    • Issues 104
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 29
    • Merge requests 29
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Gaudi
  • GaudiGaudi
  • Merge requests
  • !314

filter circular data dependencies

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Charles Leggett requested to merge leggett/Gaudi:dev/dev/CircDataDeps into master Apr 04, 2017
  • Overview 11
  • Commits 7
  • Changes 4

First check Algorithms to see if they have explicit circular data dependencies (ie both read and write DataHandles have been declared for the same object). This is an error condition.

Also, adds a boolean Property (FilterCircularDependencies) to Algorithm to selectively filter out circular data dependencies that may have been inherited from child AlgTool. After the full set of data dependencies of the Alg and its AlgTools have been assembled by the DataHandleHolderVisitor, check again for circular dependencies. If the Property is set True, cirular deps will be filtered out by removing the Input dep. A WARNING will be issued. If set False, an ERROR will be printed, and Algorithm::initialize() will return a StatusCode::FAILURE.

Current default for the Property is True. This should be changed to False in the future.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: dev/dev/CircDataDeps