Skip to content

Implement DataObjectHandleBase comparison with None.

Olli Lupton requested to merge olupton/Gaudi:patch-1 into master

Implements DataObjectHandleBase comparison with None (which always returns False). This is a proposed fix to this error in isPropertySet().

Traceback (most recent call last):
  File "/workspace/lb-stack-setup/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/scripts/gaudirun.py", line 478, in <module>
    retcode = c.run(opts.gdb,opts.ncpus)
  File "/workspace/lb-stack-setup/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/python/Gaudi/Main.py", line 246, in run
    result = self.runSerial(attach_debugger)
  File "/workspace/lb-stack-setup/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/python/Gaudi/Main.py", line 359, in runSerial
    self.basicInit()
  File "/workspace/lb-stack-setup/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/python/Gaudi/Main.py", line 328, in basicInit
    for p, v in  c.getValuedProperties().items() :
  File "/workspace/lb-stack-setup/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/python/GaudiKernel/Configurable.py", line 595, in getValuedProperties
    if self.isPropertySet(name):
  File "/workspace/lb-stack-setup/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/python/GaudiKernel/Configurable.py", line 685, in isPropertySet
    return value != default
  File "/workspace/lb-stack-setup/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/python/GaudiKernel/DataObjectHandleBase.py", line 30, in __ne__
    return not self==other
  File "/workspace/lb-stack-setup/Gaudi/InstallArea/x86_64-centos7-gcc62-opt/python/GaudiKernel/DataObjectHandleBase.py", line 24, in __eq__
    raise ValueError('Unknown equality check: type=%r, repr=%r'%(type(other), other))
ValueError: Unknown equality check: type=<type 'NoneType'>, repr=None

Merge request reports