Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Gaudi Gaudi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 124
    • Issues 124
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GaudiGaudi
  • GaudiGaudi
  • Merge requests
  • !542

deprecate Algorithm begin/end run methods

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Charles Leggett requested to merge leggett/Gaudi:dev/master/NoBeginRun into master Dec 14, 2017
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 27

Algorithms should not know about begin and end run transitions, as these concepts become fuzzy if not entirely meaningless in an environment where multiple events are processed concurrently. In the vast majority of cases, anything done in Algorithm::beginRun can be migrated to Algorithm::start, and endRun -> stop.

I've hidden the compilation warnings that are triggered by Algorithm::sysBegin/EndRun, but have not touched the ones in GaudiAlg/Sequencer as I'm not sure what LHCb wants to do with those. Eliminate the the methods right now entirely? Hide the warnings?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dev/master/NoBeginRun