Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Gaudi Gaudi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 124
    • Issues 124
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GaudiGaudi
  • GaudiGaudi
  • Merge requests
  • !763

Add `nodiscard` attribute to StatusCode (C++17)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Marco Clemencic requested to merge clemenci/Gaudi:replace-statuscodesvc-with-nodiscard into master Sep 26, 2018
  • Overview 15
  • Commits 5
  • Pipelines 12
  • Changes 59

this allow spotting unchecked StatusCodes at compile time instead of at run time.

I also fixed O(250) unchecked StatusCodes in Gaudi (in ~60 files), using the script $587.

With this we can remove StatusCodeSvc with the overhead it implies (@graven noted that removing ~StatusCode we will also save some time because the return will be done via registers).

This also remove the WARN_UNUSED macro introduced with !386 (merged) (redundant).

Edited Feb 25, 2020 by Marco Clemencic
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: replace-statuscodesvc-with-nodiscard