Skip to content
Snippets Groups Projects

feat: Update to Release 24 (!12)

Merged Matthew Feickert requested to merge feat/update-to-relase-24 into main
1 unresolved thread
Edited by Matthew Feickert

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthew Feickert changed title from feat: Update to Release 24 to feat: Update to Release 24 (!12)

    changed title from feat: Update to Release 24 to feat: Update to Release 24 (!12)

  • Matthew Feickert changed the description

    changed the description

  • added 1 commit

    • 947998ea - Update AB version in CMakeLists.txt

    Compare with previous version

    • ...
      -- Configuring the build of package: ColumnarPrototype
      CMake Error at /usr/AnalysisBase/24.2.2/InstallArea/x86_64-centos7-gcc11-opt/cmake/modules/AtlasFunctions.cmake:653 (message):
        The package name ColumnarPrototype does not match the directory name
        columnarprototype in columnarprototype.
      Call Stack (most recent call first):
        columnarprototype/CMakeLists.txt:5 (atlas_subdir)
      ...

      Not really clear why this is happening. Not sure if @krumnack has thoughts.

    • The issue is that ColumnarPrototype was checked out as columnarprototype. Renaming it should fix it.

      Not sure if there is a way to avoid that happening, essentially gitlab seems to strip all capitalization from repository names.

    • It is confusing that this is only happening in Release 24 though (Release 22 is fine), so ATLAS CMake has apparently gotten more restrictive.

      Edited by Matthew Feickert
    • Looking at the complaining snippet in /usr/AnalysisBase/24.2.2/InstallArea/x86_64-centos7-gcc11-opt/cmake/modules/AtlasFunctions.cmake

         # Get the source path of the package:
         atlas_get_package_dir( pkgDir )
      
         # Check if the package name matches the (leaf) directory name:
         get_filename_component( pkgDirName ${pkgDir} NAME )
         if( NOT "${name}" STREQUAL "${pkgDirName}" )
            message( SEND_ERROR "The package name ${name} does not match "
               "the directory name ${pkgDirName} in ${pkgDir}." )
         endif()

      it is entirely absent in /usr/AnalysisBase/22.2.113/InstallArea/x86_64-centos7-gcc11-opt/cmake/modules/AtlasFunctions.cmake

         # Get the source path of the package:
         atlas_get_package_dir( pkgDir )
      
      

      so time to go ask why this was done with exact string matching including casing, which seems unnecessary.

    • Please register or sign in to reply
  • Matthew Feickert added 2 commits

    added 2 commits

    • e7fe543b - Update to v24.2.3
    • 739b9e42 - Rename columnarprototype to ColumnarPrototype to deal with exact string matching

    Compare with previous version

  • Matthew Feickert changed the description

    changed the description

  • mentioned in commit 73b0725c

  • mentioned in commit 77519de5

Please register or sign in to reply
Loading