Changes from Marian Heil, part I
Changes from Marian Heil, part I What was not included so far, but will be included ( a closer look is needed).
- Changes to the version variables. One has to test it.
- Changes to the output location of python modules. Looks OK.
- Copying operations for *py files and dlls.
What was not included so far (not sure)
- Some formatting changes to oneliners in cmake, e.g.
set_target_properties(pyHepMC3${Python_VERSION} PROPERTIES OUTPUT_NAME pyHepMC3 )
What was not included:
- The way to call the tests. The whole idea is that no test should include arguments.
-
set(CMAKE_VERBOSE_MAKEFILE ON)
is a good thing. Compilation if for developers only and it is better to have thisON
. - a new line in the end of file is a good thing.
-
update_path()
frompyHepMC3TestUtils.py
- the code generated with binder utility should go to the source dir.
Merge request reports
Activity
Filter activity
Please register or sign in to reply