Fix or understand grid requirements

• we are getting the exception

Exception: define_limit_grid could not detect combined datacard variables COMBCARDS,COMBCARDS_POINTS,COMBCARDS_VBF,COMBCARDS_VBF_POINTS

While only COMBCARDS is defined in setup

If that is commented we get the following

Exception: define_limit_grid encountered unstable limit interpolation with grid_min (-0.00987420952879) >= grid_max (-0.0618157023564)

Something should be added in this setup, or something should be ran before launching the grid?

Example if command being attempted

law run PlotUpperLimitsAtPoint
--version $1
--pois r
--multi-datacards "

$COMBCARDS_POINTS:$

COMBCARDS_NAT_POINTS"
--datacard-names "All channels","Only Nature paper"
--use-snapshot
--show-parameters kl,kt:CV,C2V
--sort-by expected
--campaign run2
--x-log
--h-lines 1
--from-grid r,0,0,80
--UpperLimits-optimize-discretes
--UpperLimits-htcondor-cpus 2
--UpperLimitsGrid-max-runtime 30h
--UpperLimitsGrid-optimize-discretes
--UpperLimitsGrid-workflow htcondor
--UpperLimitsGrid-htcondor-cpus 2
--Snapshot-max-runtime 48h
--Snapshot-workflow htcondor
--Snapshot-test-timming
--CreateWorkspace-test-timming
--CreateWorkspace-workflow htcondor
--CreateWorkspace-custom-args "${CreateWSArgs}"
--CreateWorkspace-max-runtime 48h
--hh-model "hh_model_boosted.model_boosted_vhh"
--workers 10

OR

law run PlotUpperLimits --version legacy_v1 --pois r --scan-parameters kl,-15,26,83 --datacards "

$COMBCARDS" --use-snapshot --save-ranges --from-grid r,0,0,80 --show-parameters kt,CV,C2V --campaign run2 --hh-model "hh_model_boosted.model_boosted_vhh" --y-log --UpperLimits-optimize-discretes --UpperLimitsGrid-optimize-discretes --UpperLimitsGrid-workflow htcondor --UpperLimitsGrid-htcondor-cpus 2 --UpperLimitsGrid-max-runtime 100h --Snapshot-workflow htcondor --Snapshot-max-runtime 48h --CreateWorkspace-custom-args "$

{CreateWSArgs}" --CreateWorkspace-workflow htcondor --CreateWorkspace-max-runtime 48h --workers 15

Either give same result

mentioned in merge request !73 (merged)

mentioned in commit 26d40cca

closed with commit 26d40cca

mentioned in commit 6f6fc0d0

Sorry for bring up this issue again, I am testing the grid command with latest master branch and have the same issue:

Exception: define_limit_grid could not detect combined datacard variables COMBCARDS,COMBCARDS_POINTS,COMBCARDS_VBF,COMBCARDS_VBF_POINTS

This seems come from these lines. And I am using this setup

Hey @yilai ,

Please note that the run2 hooks were added somewhat ad-hoc for the past combination needs and might not be 100% clean and portable.

With that being said, looking at your setup I can see that the error occurs because none of the 4 variables is found in your environment. You have the variables with a _NAT suffix though, so I suggest you either remove this suffix, or (and this might be easier for you), you add the suffix also to the variable names in the line that you referred to, i.e.,

cards_vars = ["COMBCARDS_NAT", "COMBCARDS_NAT_POINTS", "COMBCARDS_VBF_NAT", "COMBCARDS_VBF_NAT_POINTS"]

Hope this helps.

Naive question. Does the name of the variable being fitted eg "COMBCARDS_NAT" or "COMBCARDS" really needs to be hardcoded somewhere?

Parallel but related question, is there some harcoding in initial grids that are saved to our common eos to pay attention to when moving stuff and/or have a recipe how to do it maybe on our gitlab for docs?