Skip to content
Snippets Groups Projects

PullsAndImpacts: enable robustFit

Closed PullsAndImpacts: enable robustFit
add_robustFit into master
Closed Benjamin Fischer requested to merge add_robustFit into master

Fixes bad PullsAndImpacts i.e. severly "overconstrained" to about +0.02/-0.0 sigma. Was introduced in 3ca8362b.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marcel Rieger
    Marcel Rieger @mrieger
    Owner

    Hi @befische ,

    Thanks for the PR but I think we should not add this by default as some channels (at least bbtt and multilepton) saw other weird things happening when enabling it. Maybe we should rather have this as an opt-in, i.e. "enable only if needed" similar to how combine does it. We should, however, mention this in the next HH meeting for other groups to check :)

    Would you be fine with that?

  • Marcel Rieger
    Marcel Rieger @mrieger
    Owner

    Closing for now. We might need to reconsider this in the future though

  • Marcel Rieger closed

    closed

Please register or sign in to reply