Make combine v9.1.0 the default, customize workspace performance flags
Compare changes
This PR contains two things:
CreateWorkspace
is running with 5 flags that increase the performance of limit and likelihood computations:
--optimize-simpdf-constraints cms
, --X-pack-asympows
, --X-optimizeMHDependency fixed
, --use-histsum
, and --no-wrappers`.
Observations:
--optimize-simpdf-constraints cms
and --use-histsum --no-wrappers
. Each of them accounts for about 50% of the performance boost.--optimize-simpdf-constraints cms
whatsoever, so it should be always safe to use that one.--use-histsum
and --no-wrappers
always have to be used together. When used alone, each of them leads to failures (either already in text2workspace.py or Segfaults in combine).--X-optimizeMHDependency fixed
only works when both --use-histsum
and --no-wrappers
are enabled, but it doesn't increase the performance on top of these two any further.--X-pack-asympows
works when used alone, but not when --optimize-simpdf-constraints cms
is enabled, unless --use-histsum
is set.--use-histsum --no-wrappers
is set, the result of FitDiagnostics is unusable as it's missing all per-channel info and postfit histograms are collapsed to single bins.Actions:
--optimize-simpdf-constraints cms
. It makes things faster and doesn't break anything.--optimize-limits
flag in CreateWorkspace now that adds the additional four flags.--optimize-limits False
.