As discussed in ATLASSIM-4948, FTFP_BERT_ATL is part of the Geant4 code-base
in recent versions (10.2 onwards), so no need to have it defined in Athena too.
No change in output observed.

`doLVL2` and `doEF` were used during Run-1 to configure the two-level
HLT. This has not been supported since a long time and was replaced by a
single `doHLT` flag. Adjust relevant python fragments.

Edward Moyse authored 4 years ago and Frank Winklmeier committed 4 years ago

Attempt to fix the CI failures.

Cleanup cmake configuration, remove unused `XercesC` dependency and
enable flake8.

Decorate zero pile-up values in case of no pile-up.

Cleanup includes:
 * Removing legacy scripts
 * Moving AthenaMP_EventService.py over to AthenaMP/python
 * Fixing CMakeLists.txt and a few client scripts

Rachid Mazini authored 4 years ago and Atlas Nightlybuild committed 4 years ago

Update Quasi-stable particle definition in GenParticleSimWhiteList

See merge request atlas/athena!38036

(cherry picked from commit 1eac7cfc)

6b976577 Update Quasi-stable particle definition in GenParticleSimWhiteList to include...

 - Prefer preincrement to postincrement for user iterators.

Rachid Mazini authored 4 years ago and Atlas Nightlybuild committed 4 years ago

New TFCSEnergyInterpolationPiecewiseLinear class for piecewise linear interpolation

See merge request atlas/athena!38095

(cherry picked from commit c5918933)

dd0cab83 New TFCSEnergyInterpolationPiecewiseLinear class for piecewise linear interpolation
ffa9240b Made m_linInterpol direct class member
66fd9218 Made logEkin[] and response[] const

Here we adapt the various clients of the `UserActionSvc` to create
(in the case of `G4AtlasAlg`, `G4LegacyTransportTool` and
`G4TransportTool`) `G4AtlasActionInitialization` or use it
(`G4AtlasRunManager`, `G4AtlasUserWorkerThreadInitialization`,
`G4AtlasWorkerRunManager`).

`G4AtlasActionInitialization` derives from `G4VUserActionInitialization`.
Classes based on  `G4VUserActionInitialization` are the recommended way
of initializing `G4UserActions` in Geant4MT. Switching to this approach
should make our Athena interface to Geant4 more standard. Currently the
class just wraps calls to the `UserActionSvc`. Ideally `G4RunActions`
would be initialized for the master thread also via the `BuildForMaster`
call. This functionality was missing in the current implementation, so
has not been added here in order to reproduce exactly the current behaviour.
Adding it requires significant refactoring which is best handled in a
separate merge request.

Update property reference for `test_MC16a_Digi_tf_configuration.py`.
This is related to the type change of Read/WriteHandleKeys.

Update the list of expected set properties. This seems to be related to
the DataHandle property type change in !36864, but it's not entirely
clear why only these two properties are affected.

Fixed the thread-association of the 2ndary action cache (and thread safety). Removed old slot-associated cache.