Scott Snyder authored 2 years ago and Edward Moyse committed 2 years ago

CscSegmentMakers: Fix typo in CscSegmentUtilTool::matchLikelihood

phi/eta mixup.
Was causing this method not to do anything.
Fixes a cppcheck warning.

Alexander Naip Tuna authored 2 years ago and Adam Edward Barton committed 2 years ago

NSW pad trigger decoding: add two more static functions for accessing channel maps

Savanna Shaw authored 2 years ago and Adam Edward Barton committed 2 years ago

CA migration for muon trigger: segment finding + MS tracking

Directly using the CA configuration for the segment finding and MS tracking in the muon trigger, wrapping to the legacy config via algorithmCAToGlobalWrapper (ATR-25086).
- Some minor restructuring of the offline configuration to support trigger use case (doesn't functionally change offline config)
- Explicitly configuring the track builder in the legacy config for inside-out reconstruction (we were picking up some configuration somewhat parasitically from legacy MS tracking configuration that broke with the partial migration to CA here)

Scott Snyder authored 2 years ago and Adam Edward Barton committed 2 years ago

MuonClusterSegmentMakerTools: Fix cppcheck warnings.

Prefer to initialize members in an initialization list.

Prefer to initialize class members in an initialization list.
Have NSWSeed::SeedMeasurement hold the direction by value rather
than via a shared_ptr --- the size isn't much larger, and this
is likely faster.

Reorder slightly to avoid cppcheck warning about use of dangling pointer.

Redundant string conversions.

Redundant null pointer test.

Redundant string conversion.

Johannes Junggeburth authored 2 years ago and Adam Edward Barton committed 2 years ago

Remove the MuonSegmentMergerTool

John Derek Chapman authored 2 years ago and Adam Edward Barton committed 2 years ago

Improved Random number Seeding for ParticleGun

Uninitialized variable.
throw without exception.

Christos Anastopoulos authored 2 years ago and Adam Edward Barton committed 2 years ago

IExtrapolator: Rename methods as to be more obvious what they do

Alexander Naip Tuna authored 2 years ago and Adam Edward Barton committed 2 years ago

NSW pads: add static functions to trigger decoding for downstream clients, and add local/global functions for center and corners

NSW pads: add static functions to trigger decoding for downstream clients, and add local/global functions for center and corners

Patrick Scholer authored 2 years ago and Adam Edward Barton committed 2 years ago

Fix nsw calib alg

Sebastian Julio Fuenzalida Garrido authored 2 years ago and Tadej Novak committed 2 years ago

STG YvsX on track plots:

Cluster on track implemented. The information from cluster is used to retrieve the position ath which the track intersects
with the STG active surface. This allow to retrieve the X and Y coordinates of the track and to perform YvsX global hit maps
per channel.

Alexander Naip Tuna authored 2 years ago and Tadej Novak committed 2 years ago

NSW pad trigger decoder: use return instead of throw in 2 places

Scott Snyder authored 2 years ago and Tadej Novak committed 2 years ago

MuonByteStreamCnvTest: Fix cppcheck warnings.

Side-effects in assertion.

Johannes Junggeburth authored 2 years ago and Tadej Novak committed 2 years ago

MdtCabling - Fix BIS78A12

Tim Martin authored 2 years ago and Tadej Novak committed 2 years ago

[ATR-26320] Add data dependency on HLT decoding to monitoring algorithms which make use  of deserialised HLT collections

Andrii Verbytskyi authored 2 years ago and Tadej Novak committed 2 years ago

cppckeck: Use final keyword for the virtual functions called in the constructor

Alexander Naip Tuna authored 2 years ago and Tadej Novak committed 2 years ago

Add Pad Trigger RDO to default muon output

John Derek Chapman authored 2 years ago and Tadej Novak committed 2 years ago

Update IGeometryBuilder interface to return a std::unique_ptr rather than a bare pointer

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

MuonPattern: Fix cppcheck warning.

Remove unused variable trackRoadType.
Fixes cppcheck warning that it's not copied by assignment.

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

MuonCondAlg: Fix cppcheck warnings.

Redundant string conversions.

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

MdtCalibUtils: Fix cppcheck warnings.

Printf format string types.
Pass objects by const reference, not by value.

Christos Anastopoulos authored 2 years ago and Walter Lampl committed 2 years ago

IExtrapolator: Remove Particle interfaces

Scott Snyder authored 2 years ago and Walter Lampl committed 2 years ago

MuonEventTPCnv: Fix cppcheck warning.

Side-effect in assert().

Pass object by const reference, not by value.

Andrii Verbytskyi authored 2 years ago and Walter Lampl committed 2 years ago

cppcheck: 	uselessCallsSubstr

Alexander Naip Tuna authored 2 years ago and Walter Lampl committed 2 years ago

sTgcPadTriggerRawDataProvider: demote INFO to DEBUG

Suppress a couple cppcheck false positives.

push_back invalidates iterators.
Redundant null pointer check.