ACTS barcode FIXME comments

Tracking/Acts/ActsObjectDecoration/src/PixelClusterSiHitDecoratorAlg.cxx

@@ -164,12 +164,12 @@ namespace ActsTrk {
 	const xAOD::TrackMeasurementValidation* measurement = measurements->at(cluster->index());
 	ATH_CHECK(measurement->identifier() == cluster->identifier() );
 
-	auto [word, depositsBarcode, depositsEnergy] = ActsTrk::detail::getSDOInformation(cluster->rdoList(), *sdos);
+	auto [word, depositsBarcode, depositsEnergy] = ActsTrk::detail::getSDOInformation(cluster->rdoList(), *sdos); // FIXME barcode-based
 	std::vector<SiHit> compatibleSiHits = findAllHitsCompatibleWithCluster(*cluster, *element, siHitsWithCurrentHash, depositsBarcode);
 
 	auto [energyDeposit, meanTime, barcode, pdgid,
 	      startPosX, startPosY, startPosZ,
-	      endPosX, endPosY, endPosZ] = ActsTrk::detail::getSiHitInformation(*element, compatibleSiHits);
+	      endPosX, endPosY, endPosZ] = ActsTrk::detail::getSiHitInformation(*element, compatibleSiHits); // FIXME barcode-based
 	
 	// attach SDO decorations
 	decor_sdo_words(*measurement) = std::move(word);
@@ -223,9 +223,9 @@ namespace ActsTrk {
 	} // list on rdos
 	
       } else { // not m_useSiHitsGeometryMatching
-	auto siHitBarcode = HepMC::barcode(siHit->particleLink());       
+	auto siHitBarcode = HepMC::barcode(siHit->particleLink()); // FIXME barcode-based
 	for ( const std::vector<int>& barcodeSDOColl : sdoTracks ) {
-	  if (std::find(barcodeSDOColl.begin(), barcodeSDOColl.end(), siHitBarcode) == barcodeSDOColl.end()) continue;
+	  if (std::find(barcodeSDOColl.begin(), barcodeSDOColl.end(), siHitBarcode) == barcodeSDOColl.end()) continue; // FIXME barcode-based
 	  multiMatchingHits.push_back(siHit);	
 	  break;
 	}	
@@ -298,7 +298,7 @@ namespace ActsTrk {
 				  highestXPos->localEndPosition(),
 				  energyDep,
 				  time,
-				  HepMC::barcode((*siHitIter)->particleLink()),
+				  HepMC::barcode((*siHitIter)->particleLink()), // FIXME barcode-based
 				  0, // 0 for pixel 1 for strip
 				  (*siHitIter)->getBarrelEndcap(),
 				  (*siHitIter)->getLayerDisk(),

Tracking/Acts/ActsObjectDecoration/src/StripClusterSiHitDecoratorAlg.cxx

@@ -164,12 +164,12 @@ namespace ActsTrk {
 	const xAOD::TrackMeasurementValidation* measurement = measurements->at(cluster->index());
 	ATH_CHECK(measurement->identifier() == cluster->identifier() );
 
-	auto [word, depositsBarcode, depositsEnergy] = ActsTrk::detail::getSDOInformation(cluster->rdoList(), *sdos);
+	auto [word, depositsBarcode, depositsEnergy] = ActsTrk::detail::getSDOInformation(cluster->rdoList(), *sdos); // FIXME barcode-based
 	std::vector<SiHit> compatibleSiHits = findAllHitsCompatibleWithCluster(*cluster, *element, siHitsWithCurrentHash);
 
 	auto [energyDeposit, meanTime, barcode, pdgid,
 	      startPosX, startPosY, startPosZ,
-	      endPosX, endPosY, endPosZ] = ActsTrk::detail::getSiHitInformation(*element, compatibleSiHits);
+	      endPosX, endPosY, endPosZ] = ActsTrk::detail::getSiHitInformation(*element, compatibleSiHits); // FIXME barcode-based
 	
 	// attach SDO decorations
 	decor_sdo_words(*measurement) = std::move(word);
@@ -285,7 +285,7 @@ namespace ActsTrk {
 				  highestXPos->localEndPosition(),
 				  energyDep,
 				  time,
-				  HepMC::barcode((*siHitIter)->particleLink()),
+				  HepMC::barcode((*siHitIter)->particleLink()), // FIXME barcode-based
 				  1, // 0 for pixel 1 for strip
 				  (*siHitIter)->getBarrelEndcap(),
 				  (*siHitIter)->getLayerDisk(),

Tracking/Acts/ActsObjectDecoration/src/detail/Utilities.cxx

@@ -28,7 +28,7 @@ namespace ActsTrk::detail {
 
       unsigned int nDepos {0};
       for (const auto& deposit: pos->second.getdeposits()) {
-	if (deposit.first) sdoDepBC[nDepos] = HepMC::barcode(deposit.first);
+	if (deposit.first) sdoDepBC[nDepos] = HepMC::barcode(deposit.first); // FIXME barcode-based
 	sdoDepEnergy[nDepos] = deposit.second;
 	++nDepos;
       }
@@ -78,7 +78,7 @@ namespace ActsTrk::detail {
       sihit_meanTime[hitNumber] =  sihit.meanTime() ;
 
       const HepMcParticleLink& HMPL = sihit.particleLink();
-      sihit_barcode[hitNumber] = HepMC::barcode(HMPL) ;
+      sihit_barcode[hitNumber] = HepMC::barcode(HMPL); // FIXME barcode-based
       if( HMPL.isValid() ){
         sihit_pdgid[hitNumber] = HMPL->pdg_id();
       }