Merge branch 'cppcheck.FourMomUtils-20200901' into 'master'

FourMomUtils: Fix cppcheck warnings.

See merge request atlas/athena!36043

Event/FourMomUtils/FourMomUtils/ForwardTerm.h

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef FOURMOMUTILS_FORWARDTERM_H
@@ -15,8 +15,8 @@ namespace FourMomUtils
 
   typedef INavigable4MomentumCollection::const_iterator I4MomIter_t;
 
-  double forwardTerm( const I4MomIter_t iBeg,
-          const I4MomIter_t iEnd,
+  double forwardTerm( const I4MomIter_t& iBeg,
+          const I4MomIter_t& iEnd,
           double m_central,
           bool useThreeD = false );
 

Event/FourMomUtils/FourMomUtils/FoxWolfram.h

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef FOURMOMUTILS_FOXWOLFRAM_H
@@ -17,8 +17,8 @@ namespace FourMomUtils
 
   typedef INavigable4MomentumCollection::const_iterator I4MomIter_t;
 
-  bool foxWolfram( const I4MomIter_t iBeg,
-       const I4MomIter_t iEnd,
+  bool foxWolfram( const I4MomIter_t& iBeg,
+       const I4MomIter_t& iEnd,
                    std::vector<double>& H, unsigned int order = 5 );
 
   inline

Event/FourMomUtils/FourMomUtils/JetBroadening.h

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef FOURMOMUTILS_JETBROADENING_H
@@ -15,7 +15,7 @@ namespace FourMomUtils
 {
   typedef INavigable4MomentumCollection::const_iterator I4MomIter_t;
 
-  bool jetBroadening(const I4MomIter_t iBeg, const I4MomIter_t iEnd,
+  bool jetBroadening(const I4MomIter_t& iBeg, const I4MomIter_t& iEnd,
                      double& wideJetBroadening, double& totalJetBroadening,
                      CLHEP::Hep3Vector thrust, bool useThreeD = false );
 

Event/FourMomUtils/FourMomUtils/JetMasses.h

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef FOURMOMUTILS_JETMASSES_H
@@ -15,7 +15,7 @@ namespace FourMomUtils
 {
   typedef INavigable4MomentumCollection::const_iterator I4MomIter_t;
 
-  bool jetMasses(const I4MomIter_t iBeg, const I4MomIter_t iEnd,
+  bool jetMasses(const I4MomIter_t& iBeg, const I4MomIter_t& iEnd,
                  double& heavyJetMass, double& lightJetMass,
                  CLHEP::Hep3Vector thrust );
 

Event/FourMomUtils/FourMomUtils/Thrust.h

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #ifndef FOURMOMUTILS_THRUST_H
@@ -16,7 +16,7 @@ namespace FourMomUtils
 
   typedef INavigable4MomentumCollection::const_iterator I4MomIter_t;
 
-  CLHEP::Hep3Vector thrust( const I4MomIter_t iBeg, const I4MomIter_t iEnd,
+  CLHEP::Hep3Vector thrust( const I4MomIter_t& iBeg, const I4MomIter_t& iEnd,
                             double& thrust_major, double& thrust_minor,
                             bool useThreeD=false );
 

Event/FourMomUtils/src/ForwardTerm.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #include <cmath>
@@ -15,8 +15,8 @@ using std::abs;
 using std::exp;
 
 double
-forwardTerm( const I4MomIter_t iBeg,
-       const I4MomIter_t iEnd,
+forwardTerm( const I4MomIter_t& iBeg,
+       const I4MomIter_t& iEnd,
        double central, bool useThreeD )
 {
   double Q = 0;

Event/FourMomUtils/src/FoxWolfram.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "FourMomUtils/FoxWolfram.h"
@@ -17,7 +17,7 @@ using std::exp;
 using std::cos;
 
 bool
-foxWolfram( const I4MomIter_t iBeg, const I4MomIter_t iEnd,
+foxWolfram( const I4MomIter_t& iBeg, const I4MomIter_t& iEnd,
       std::vector<double>& H, unsigned int order )
 {
   // this is the vector of results

Event/FourMomUtils/src/JetBroadening.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "FourMomUtils/JetBroadening.h"
@@ -14,7 +14,7 @@ namespace FourMomUtils {
 using std::abs;
 using std::exp;
 
-bool jetBroadening( const I4MomIter_t iBeg, const I4MomIter_t iEnd,
+bool jetBroadening( const I4MomIter_t& iBeg, const I4MomIter_t& iEnd,
         double& wideJetBroadening, double& totalJetBroadening,
         CLHEP::Hep3Vector thrust, bool useThreeD )
 {

Event/FourMomUtils/src/JetMasses.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "FourMomUtils/JetMasses.h"
@@ -15,7 +15,7 @@ using std::abs;
 using std::exp;
 
 bool
-jetMasses( const I4MomIter_t iBeg, const I4MomIter_t iEnd,
+jetMasses( const I4MomIter_t& iBeg, const I4MomIter_t& iEnd,
      double& heavyJetMass, double& lightJetMass,
      CLHEP::Hep3Vector thrust )
 {

Event/FourMomUtils/src/Thrust.cxx

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 #include "FourMomUtils/Thrust.h"
@@ -16,7 +16,7 @@ using std::abs;
 using std::exp;
 
 CLHEP::Hep3Vector
-thrust( const I4MomIter_t iBeg, const I4MomIter_t iEnd,
+thrust( const I4MomIter_t& iBeg, const I4MomIter_t& iEnd,
   double& thrust_major, double& thrust_minor, bool useThreeD)
 {
   /*